jonmmease opened a new pull request, #4848: URL: https://github.com/apache/arrow-datafusion/pull/4848
# Which issue does this PR close? Follow on to https://github.com/apache/arrow-datafusion/pull/4846 for `var`, `var_pop`, `stddev`, and `stddev_pop`. The actual `retract_batch` function was already implemented, but it looks like the `create_sliding_accumulator` implementations weren't added previously so it wasn't possible to use these aggregate functions in window expressions that use custom frames. # Are these changes tested? The test added in effc4728912684f63b2e4ce837ae1b1816796480 will fail until https://github.com/apache/arrow-datafusion/pull/4847 is merged and this branch is updated. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? `var`, `var_pop`, `stddev`, and `stddev_pop` will now work in window expressions that use custom frames rather than raising an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
