cyb70289 commented on PR #15201: URL: https://github.com/apache/arrow/pull/15201#issuecomment-1374746931
> One thought about the number of benchmarks -- there is a benchmark for every type and round mode (10 each). Some alternatives could be to try to fold the round mode tests into the type (for less visibility) or come up with a "less frequently used" benchmark concept if having less benchmarks is ideal. It does looks too many benchmarks are generated. And I guess most of them are similar. How long will all these cases run? If the round modes don't impact performance, I agree that we can only test one of them. And probably few data types, e.g., int64/uint64/double. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
