alamb commented on code in PR #4836:
URL: https://github.com/apache/arrow-datafusion/pull/4836#discussion_r1064111911
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -846,26 +846,23 @@ SELECT count(1 + 1)
----
1
-# FIX: "CSV Writer does not support List(Field { name: \"item\", data_type:
Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: None })
data type")
Review Comment:
👍
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -976,6 +973,7 @@ select max(c1) from d_table
----
110.009
+# FIX: doesn't check datatype
Review Comment:
This is tracked by https://github.com/apache/arrow-datafusion/issues/4499
##########
datafusion/core/tests/sql/aggregates.rs:
##########
@@ -20,24 +20,6 @@ use datafusion::scalar::ScalarValue;
use datafusion::test_util::scan_empty;
use datafusion_common::cast::as_float64_array;
-#[tokio::test]
-async fn csv_query_avg_multi_batch() -> Result<()> {
Review Comment:
Here is the corresponding test in .slt
https://github.com/apache/arrow-datafusion/blob/dcd52ee3d87c4dd9e2c176165e9e20644f66988b/datafusion/core/tests/sqllogictests/test_files/aggregate.slt#L21-L25
👍
##########
datafusion/core/tests/sql/arrow_typeof.rs:
##########
@@ -1,139 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-use super::*;
-
-#[tokio::test]
-async fn arrow_typeof_null() -> Result<()> {
- let ctx = SessionContext::new();
- let sql = "SELECT arrow_typeof(null)";
- let actual = execute(&ctx, sql).await;
- let expected = "Null";
- assert_eq!(expected, &actual[0][0]);
-
- Ok(())
-}
-
-#[tokio::test]
-async fn arrow_typeof_boolean() -> Result<()> {
Review Comment:
I double checked -- here is the corresponding .slt file:
https://github.com/apache/arrow-datafusion/blob/dcd52ee3d87c4dd9e2c176165e9e20644f66988b/datafusion/core/tests/sqllogictests/test_files/arrow_typeof.slt#L26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
