jackwener commented on PR #4842: URL: https://github.com/apache/arrow-datafusion/pull/4842#issuecomment-1374786211
> > e.g: some rule recurse inside themselves, and alway return Ok(Some()) > > It's expected behavior. > > Why don't we return None if the rule can't optimize the plan is this scenario? Some rule I modify them to avoid self-recurse, those rules is ok. But other rules still use original code, always return Ok(Some()) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
