kszucs commented on a change in pull request #8567:
URL: https://github.com/apache/arrow/pull/8567#discussion_r515951306
##########
File path: .github/workflows/rust.yml
##########
@@ -68,7 +68,7 @@ jobs:
uses: actions/cache@v1
with:
path: .docker
- key: debian-10-rust-${{ hashFiles('rust/**.rs') }}
+ key: debian-10-rust-${{ hashFiles('rust/**/**.rs',
'rust/**/Cargo.toml') }}
Review comment:
According to [GHA
docs](https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet)
`**` should match nested directories as well.
##########
File path: .github/workflows/rust.yml
##########
@@ -118,8 +118,8 @@ jobs:
uses: actions/cache@v1
with:
path: rust/target
- key: windows-rust-${{ hashFiles('rust/**.rs') }}
- restore-keys: windows-rust-
+ key: windows-rust-v1-${{ hashFiles('rust/**/**.rs',
'rust/**/Cargo.toml') }}
Review comment:
Is `v1` used here for invalidating the previous cache?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
