alamb commented on issue #4462:
URL: 
https://github.com/apache/arrow-datafusion/issues/4462#issuecomment-1374882900

   > So do we agree, that the way to go is to force all .slt tests to have 
expected outputs, and then simply verify the same tests with 
Postgres/Datafusion runnens?
   
   Yes, that would be my preferred solution -- it will ensure that DataFusion 
is producing consistent answers with Postgres and that the answers can also be 
verified by looking at the `slt` file
   
   Just so it is clear, I do not expect every single  .slt file now (or ever) 
to produce the same answers as postgres (as datafusion supports different 
syntax and likely also has existing discrepancies, etc). I think we should 
start simple with a few explicitly marked files used to do "with postgres 
verification" and we can expand the scope of which files are tested against slt 
files over time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to