mingmwang commented on PR #4839:
URL: 
https://github.com/apache/arrow-datafusion/pull/4839#issuecomment-1375041839

   @mustafasrepo @alamb 
   Generally, I am OK with this change.  I will take a closer look at the PR 
today.
   
   For the original `OptimizeSorts` rule, I just have a feeling that the 
implementation was too complex and I think maybe there are ways to simply it. 
And I also have a feeling that the rule should be implemented in a top-down 
approach. I will try to do some test also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to