alamb commented on code in PR #3494:
URL: https://github.com/apache/arrow-rs/pull/3494#discussion_r1064602208
##########
arrow-cast/src/parse.rs:
##########
@@ -121,6 +121,14 @@ pub fn string_to_timestamp_nanos(s: &str) -> Result<i64,
ArrowError> {
return Ok(ts.timestamp_nanos());
}
+ // without a timezone specifier as a local time, only date
+ // Example: 2020-09-08
+ if let Ok(ts) =
+ NaiveDateTime::parse_from_str(&format!("{} 00:00:00", s), "%Y-%m-%d
%H:%M:%S")
Review Comment:
this allocates a new string which might take some serious time -- perhaps it
would be possible to parse using `NaiveDate` and then convert the NaiveDate to
a NaiveDateTime ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
