nealrichardson commented on PR #15252: URL: https://github.com/apache/arrow/pull/15252#issuecomment-1375760926
> Not sure why `row.names` was ever removed. [This is the commit](https://github.com/sirensolutions/arrow/commit/a6d531a3f409706d7dcde4562913c8589be3402a#diff-659e9fa6b66e5a72b4e3f9ac79ffddf08f92d9ea3d7aa45bd8c73b9a022fa2e5) that added the entire metadata.R, it seems a part of an unrelated effort. I believe the other attributes listed in `removed_attributes` were removed because they're serialized/deserialized by other means. `row.names` doesn't belong there. > > * Closes: [[R] arrow::write_feather doesn't save row names #15246](https://github.com/apache/arrow/issues/15246) row names are removed from metadata for a few reasons: * They are length `n`, so they can easily get too large to store in schema metadata * If rows are filtered in arrow prior to converting to an R data.frame, the row names won't be filtered (they're not in the table), and their length won't match the resulting data. If you want to keep row names, they need to be added to the table. We could try to develop a convention for how to do that automatically in the R package, though the best solution is probably for you to be explicit about adding the column to the table yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
