wjones127 commented on code in PR #15210:
URL: https://github.com/apache/arrow/pull/15210#discussion_r1064838323
##########
cpp/src/arrow/array/array_list_test.cc:
##########
@@ -509,6 +509,18 @@ class TestListArray : public ::testing::Test {
ASSERT_RAISES(Invalid, ValidateOffsets(2, {0, 7, 4}, values));
}
+ void TestSliced() {
+ auto arr = ArrayFromJSON(list(int16()), "[[1, 2], [3, 4, 5], [6], [7,
8]]");
+
+ auto arr_sliced = arr->Slice(0, 2);
+ auto expected_sliced = ArrayFromJSON(list(int16()), "[[1, 2], [3, 4, 5]]");
+ AssertArraysEqual(*expected_sliced, *arr_sliced);
+
+ auto values = checked_cast<ListArray*>(arr_sliced.get())->values();
+ auto expected_values = ArrayFromJSON(int16(), "[1, 2, 3, 4, 5]");
+ AssertArraysEqual(*expected_values, *values);
Review Comment:
I should add a test.
And you might be right about flatten, it does include the nulls in the
values (not the list). For some reason earlier I had gotten the impression it
doesn't, while I was debugging.
```python
>>> import pyarrow as pa
>>> arr = pa.array([[1, 2], [3, 4, 5], [6, None], [7, 8]])
>>> arr.flatten()
<pyarrow.lib.Int64Array object at 0x129b2c820>
[
1,
2,
3,
4,
5,
6,
null,
7,
8
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
