fatemehp commented on code in PR #14603:
URL: https://github.com/apache/arrow/pull/14603#discussion_r1065132773
##########
cpp/src/parquet/statistics.h:
##########
@@ -216,6 +216,14 @@ class PARQUET_EXPORT Statistics {
bool has_distinct_count,
::arrow::MemoryPool* pool = ::arrow::default_memory_pool());
+ // Helper function to convert EncodedStatistics to Statistics.
+ // EncodedStatistics does not contain number of non-null values, and it can
be
+ // passed using the num_values parameter.
+ static std::shared_ptr<Statistics> Make(
+ const ColumnDescriptor* descr, const EncodedStatistics*
encoded_statistics,
+ int64_t num_values = -1,
Review Comment:
We decided to add a convenient way to convert an EncodedStatistics to
Statistics. However, the encoded statistics misses the number of non-null
values that is required for making Statistics. So, I made an optional argument
for it.
Please see here:
https://github.com/apache/arrow/pull/14603#discussion_r1048484566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
