thisisnic commented on code in PR #15270:
URL: https://github.com/apache/arrow/pull/15270#discussion_r1065979107
##########
r/tests/testthat/test-csv.R:
##########
@@ -664,3 +664,27 @@ test_that("Shows an error message when trying to read a
timestamp with time zone
"CSV conversion error to timestamp\\[ns\\]: expected no zone offset in"
)
})
+
+test_that("CSV reading/parsing/convert options can be passed in as lists", {
+ tf <- tempfile()
+ on.exit(unlink(tf))
+
+ writeLines('"x"\nNA\nNA\n"NULL"\n\n"foo"\n', tf, )
+ readLines(tf)
Review Comment:
What's the impact of creating temporary files? We could looks to make it
more efficient (having a single tempfile we overwrite each time perhaps?) if
it's slowing things down, though I would prefer to have them keep using files
given that this is the topic of these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
