ygf11 commented on issue #4844:
URL:
https://github.com/apache/arrow-datafusion/issues/4844#issuecomment-1377515824
I meet a strange problem when I do the pr #4866.
After I fix the test, the tcph-q11 will panic when run sqllogictests(the
plan of q11 is modified), the direct panic message:
`thread 'tokio-runtime-worker' panicked at 'partition not used yet',
datafusion/core/src/physical_plan/repartition.rs:405:14
...
at tests/sqllogictests/test_files/tpch.slt:456`.
I have no idea about it now, need to investigate more.
More info:
https://github.com/apache/arrow-datafusion/actions/runs/3884323174/jobs/6626733651
To not block the release, I think maybe we can skip `EliminateCrossJoin`
rule when it meet any inner-join input who has non-empty filter(this is
consistent with datafusion 15).
With the patch, the sql of this issue will get the correct result.
For the feature of #4866, some query in datafusion 15 will get wrong result,
and if we skip `EliminateCrossJoin`, datafusion 16(release soon) will get
correct result, although the plan is not better optimized.
cc @alamb @liukun4515 @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
