wjones127 commented on code in PR #15270:
URL: https://github.com/apache/arrow/pull/15270#discussion_r1066065141
##########
r/tests/testthat/test-csv.R:
##########
@@ -664,3 +664,27 @@ test_that("Shows an error message when trying to read a
timestamp with time zone
"CSV conversion error to timestamp\\[ns\\]: expected no zone offset in"
)
})
+
+test_that("CSV reading/parsing/convert options can be passed in as lists", {
+ tf <- tempfile()
+ on.exit(unlink(tf))
+
+ writeLines('"x"\nNA\nNA\n"NULL"\n\n"foo"\n', tf, )
+ readLines(tf)
Review Comment:
Just slowing things down. The C++ tests generally write to buffers, not
files, for single file tests. But if people would prefer to keep as files
that's fine too.
> though I would prefer to have them keep using files given that this is the
topic of these tests.
If there is a test that is specifically about the interaction of CSV data
and the filesystem, I agree that makes sense. For example, writing a dataset
and verifying the directory structure on disk is expected. But most of these
don't really care about the filesystem; writing CSV data to a buffer is just as
valid as to a temp file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
