mapleFU commented on PR #15241:
URL: https://github.com/apache/arrow/pull/15241#issuecomment-1377612194

   > Perhaps you can use the encoder and manually change the last bitwidths in 
the output?
   
   Sure, it's easy to write that in my personal develop enviroment. But I 
cannot submit these "mock" code to the codebase, which make writing unit test a 
bit more trickey.
   
   In my local machine, I can just use 
   
   ```
      for (uint32_t i = num_miniblocks; i < mini_blocks_per_block_; i++) {
   -    bit_width_data[i] = 0;
   +    //    bit_width_data[i] = 0;
   +    bit_width_data[i] = static_cast<uint8_t>(random());
      }
   ```
   
   and run roundtrip tests. But in unit test, I should submit a test file or a 
string. And I cannot test too much cases, because I need to paste the whole 
string here.
   
   By the way, do you think using Hex to represent binary is ok? And if not ok, 
is there some good example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to