paleolimbot commented on PR #13890: URL: https://github.com/apache/arrow/pull/13890#issuecomment-1377633743
If I'm reading this properly, `as.integer()` on a timestamp will error? If that's the case, this wouldn't be a breaking change? In any case silently ignoring fractional seconds seems worse? I took a quick skim and I don't see any problems off the top of my head. There might possibly be a performance hit from the added complexity of the function but my preference is always safety >>> speed (until somebody complains). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
