viirya commented on code in PR #3482:
URL: https://github.com/apache/arrow-rs/pull/3482#discussion_r1066114889
##########
arrow/tests/array_cast.rs:
##########
@@ -411,7 +411,9 @@ fn get_all_types() -> Vec<DataType> {
),
Dictionary(Box::new(DataType::Int8), Box::new(DataType::Int32)),
Dictionary(Box::new(DataType::Int16), Box::new(DataType::Utf8)),
+ Dictionary(Box::new(DataType::Int16), Box::new(DataType::Binary)),
Dictionary(Box::new(DataType::UInt32), Box::new(DataType::Utf8)),
+ Dictionary(Box::new(DataType::UInt32), Box::new(DataType::Binary)),
Review Comment:
I just picked it following other existing types. Maybe as a improvement, I
can refactor this in a separate pr to iterate all possible dictionary key
types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
