tustvold commented on code in PR #3502:
URL: https://github.com/apache/arrow-rs/pull/3502#discussion_r1066161493
##########
arrow-ord/src/comparison.rs:
##########
@@ -35,7 +35,7 @@ use arrow_select::take::take;
/// Helper function to perform boolean lambda function on values from two
array accessors, this
/// version does not attempt to use SIMD.
-fn compare_op<T: ArrayAccessor, S: ArrayAccessor, F>(
+pub fn compare_op<T: ArrayAccessor, S: ArrayAccessor, F>(
Review Comment:
I think I would rather not make these public, even it results in a bit of
duplication
##########
arrow-string/Cargo.toml:
##########
@@ -42,6 +42,7 @@ arrow-buffer = { version = "30.0.0", path = "../arrow-buffer"
}
arrow-data = { version = "30.0.0", path = "../arrow-data" }
arrow-schema = { version = "30.0.0", path = "../arrow-schema" }
arrow-array = { version = "30.0.0", path = "../arrow-array" }
+arrow-ord = { version = "30.0.0", path = "../arrow-ord" }
Review Comment:
Is there some way to avoid this, e.g. a little copy paste, arrow-ord is a
really heavy dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
