kevingurney commented on PR #15250: URL: https://github.com/apache/arrow/pull/15250#issuecomment-1378992620
@jorisvandenbossche - that's a great point about the comments being included in the commit message. Personally, I like the new template (especially how the comments help guide contributors on what to write). However, I agree that the merge script including comments in the commit message is not ideal. Could we have the the merge script remove the comments automatically? Also, I think having the pull request description (as opposed to just the title) in the commit message is preferable because that keeps the rationale for the changes and associated implementation info directly in the Git history for future reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
