terencehonles edited a comment on pull request #8533: URL: https://github.com/apache/arrow/pull/8533#issuecomment-721815501
> CI failures are unrelated. Merging @bkietz I've bisected the commit history, and it does look like [this change](https://github.com/apache/arrow/pull/8533/files#diff-2b5392b203328a6b9e7ff692e51eb39691cc1d05329882bef0200f0d9bd51f84R57) ```diff diff --git a/cpp/src/arrow/io/memory.cc b/cpp/src/arrow/io/memory.cc index 1cde5e64e..88f006fe0 100644 --- a/cpp/src/arrow/io/memory.cc +++ b/cpp/src/arrow/io/memory.cc @@ -54,7 +54,7 @@ BufferOutputStream::BufferOutputStream(const std::shared_ptr<ResizableBuffer>& b Result<std::shared_ptr<BufferOutputStream>> BufferOutputStream::Create( int64_t initial_capacity, MemoryPool* pool) { // ctor is private, so cannot use make_shared + DCHECK_NE(pool, nullptr); auto ptr = std::shared_ptr<BufferOutputStream>(new BufferOutputStream); RETURN_NOT_OK(ptr->Reset(initial_capacity, pool)); return ptr; ``` is "responsible" for breaking the JNI status check (you can also see it was passing on the first commit in this PR https://github.com/apache/arrow/runs/1310578738 and then failing at the end https://github.com/apache/arrow/runs/1329149428). I am not familiar with the code, and I was hoping for you to possibly help me understand why the check was added and why it might be segfaulting the test java/adapter/orc/src/test/java/org/apache/arrow/adapter/orc/OrcReaderTest.java. I have experimented with removing the check and the test passes as expected, but if the check was added to catch something I'd rather not cover it up. I noticed there were two follow ups ARROW-10420 and ARROW-10421 and I was wondering if this might be related? Edit: since the runs above were not merged and their branch was deleted it looks like GitHub dropped the logs. This is the specific test error I am referring to (grabbed from a run on the `master` branch) https://github.com/apache/arrow/runs/1351819845#step:8:7374 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
