kou commented on PR #33613:
URL: https://github.com/apache/arrow/pull/33613#issuecomment-1379495206

   > The curl/ssl runtime on 10.13 results in a segfault when the process exits 
(even though all tests pass), so we get a spurious failure on our 10.13 runner 
test.
   
   Oh... How about disabling S3 support instead of skipping S3 tests?
   
   ```diff
   diff --git a/dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb 
b/dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb
   index 84206978f3..b5f5158cde 100644
   --- a/dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb
   +++ b/dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb
   @@ -35,7 +35,7 @@ class ApacheArrowStatic < Formula
    
      depends_on "boost" => :build
      depends_on "cmake" => :build
   -  depends_on "aws-sdk-cpp-static"
   +  depends_on "aws-sdk-cpp-static" if MacOS.version > :hige_sierra
      depends_on "brotli"
      depends_on "lz4"
      depends_on "snappy"
   @@ -62,7 +62,7 @@ class ApacheArrowStatic < Formula
          -DARROW_JSON=ON
          -DARROW_MIMALLOC=ON
          -DARROW_PARQUET=ON
   -      -DARROW_S3=ON
   +      -DARROW_S3=#{MacOS.version > :hige_sierra ? "ON" : "OFF"}
          -DARROW_VERBOSE_THIRDPARTY_BUILD=ON
          -DARROW_WITH_BROTLI=ON
          -DARROW_WITH_BZ2=ON
   diff --git a/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb 
b/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb
   index cb55c3a7d9..cb09d8f614 100644
   --- a/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb
   +++ b/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb
   @@ -32,7 +32,7 @@ class ApacheArrow < Formula
      # NOTE: if you add something here, be sure to add to PKG_LIBS in 
r/tools/autobrew
      depends_on "boost" => :build
      depends_on "cmake" => :build
   -  depends_on "aws-sdk-cpp"
   +  depends_on "aws-sdk-cpp" if MacOS.version > :hige_sierra
      depends_on "brotli"
      depends_on "lz4"
      depends_on "snappy"
   @@ -54,7 +54,7 @@ class ApacheArrow < Formula
          -DARROW_JSON=ON
          -DARROW_MIMALLOC=ON
          -DARROW_PARQUET=ON
   -      -DARROW_S3=ON
   +      -DARROW_S3=#{MacOS.version > :high_sierra ? "ON" : "OFF"}
          -DARROW_VERBOSE_THIRDPARTY_BUILD=ON
          -DARROW_WITH_BROTLI=ON
          -DARROW_WITH_BZ2=ON
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to