kou commented on issue #15287:
URL: https://github.com/apache/arrow/issues/15287#issuecomment-1379511152
> Is it better to ignore `left_suffix` and `right_suffix` when
`merge_key_values` is `true`?
> I think only one key is used when column is merged. It may be left_key and
do not need renaming.
OK. Then, how about `table.join(right, :KEY)` merges `KEY` values instead of
adding new `merge_key_values` option? (`table.join(right, [:KEY])` and
`table.join(right, {left: :KEY, right: :KEY})` don't merge.)
> Are default values `left_suffix="", right_suffix="",
merge_key_values=false` to ensure backward compatibility?
Yes but we can change the default `keys`. If `column_names &
right.column_names` only have 1 element, we can use `(column_names &
right.column_names)[0]` to merge key values by default. Because `keys=nil`
isn't released yet. (We don't need to think about backward compatibility.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
