lidavidm commented on PR #14082: URL: https://github.com/apache/arrow/pull/14082#issuecomment-1379527394
The other problem I remember struggling with is that Protobuf on Windows doesn't really support the dllexport annotations (it's technically there, but broken, and upstream isn't really interested). So it might not be possible to move all the Protobuf generated code into a separate library, either. On Wed, Jan 11, 2023, at 16:29, Weston Pace wrote: > > >> >> I think splitting PyArrow into different wheels is a fantasy more than >> an actionable project for now, given the technical hurdles. >> > In that case how about a single `proto` folder at the root of `cpp` that contains all proto files used in any module and generates a single libarrow_proto.so (name negotiable)? It should be pretty small to always generate all proto (e.g. always generate flight sql proto or substrait proto even if we aren't compiling that module) It would be simpler at least. > > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/arrow/pull/14082#issuecomment-1379507325>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQB32NNALDGXPDL7DVRPTWR4Q2TANCNFSM6AAAAAAQIZUROI>. > You are receiving this because you were mentioned.Message ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
