adamreeve commented on PR #33603: URL: https://github.com/apache/arrow/pull/33603#issuecomment-1379539076
Thanks @lidavidm, yes I think having a separate package would make sense for dotnet too, and maybe that can be added in a separate PR so for now I've stripped this back to remove the reflection based implementation and just have an implementation in the test project. I've also renamed things to be a bit more consistent with the Java API, although I've kept the `ICompressionCodec` API more narrowly focused so it only deals with decompression of dotnet memory buffers and Arrow buffer creation is handled by the internal `IBufferCreator` implementation, whereas in the Java API this is part of the `CompressionCodec` interface. One question I have is whether it makes sense for the public compression API (`ICompressionCodec` and `ICompressionCodecFactory`) to live in the `Apache.Arrow.Ipc` namespace, or whether this should be moved down to `Apache.Arrow` if there's a possibility it might be used outside of the IPC format? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
