amoeba commented on issue #33538: URL: https://github.com/apache/arrow/issues/33538#issuecomment-1379557603
Just catching up here, It looks like there's rough consensus around what we'd like to promote to the public API: - FromJSON helpers (from `arrow/testing/gtest_util.h`) - Assertion helpers (from `arrow/testing/gtest_util.h`), both macros (e.g., `ASSERT_OK_AND_ASSIGN`) and functions (e.g., `AssertArraysEqual`) - Random generators (from `arrow/testing/random.h`) The main question I have is whether we want to keep the above in `libarrow_testing` or do the necessary refactor to include them in `libarrow` or an existing/new target lib. I think the former makes more sense due to the dependence on gtest (unless we abstract them as @rtpsw suggests). Any advice here would be helpful since I'm not overly familiar with the conventions here. PS: @rok can you update the issue title to cover the new scope? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
