alamb commented on issue #4875:
URL:
https://github.com/apache/arrow-datafusion/issues/4875#issuecomment-1379589573
> @alamb But in your example 2262 year doesn't look correctly 🤔 It's
probably even worse, silent error.
I bet you are right that the calculation sliently overflows, but only on
release builds
-- I bet it is because I tested using a release build (where the overflow is
not checked) I wonder
```shell
# on master at 315f5b9848d3a1218ded9a1113ac4e8e8a90272f
$ cargo run
Running `/Users/alamb/Software/target-df2/debug/datafusion-cli`
DataFusion CLI v16.0.0
❯ select '1677-06-14T07:29:01.256'::timestamp;
thread 'main' panicked at 'attempt to multiply with overflow',
/Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.23/src/naive/datetime/mod.rs:426:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
Then I checked out 15.0.0:
```shell
$ git checkout 15.0.0
$ cargo run
Finished dev [unoptimized + debuginfo] target(s) in 0.28s
Running `/Users/alamb/Software/target-df2/debug/datafusion-cli`
DataFusion CLI v15.0.0
❯ select '1677-06-14T07:29:01.256'::timestamp
;
thread 'main' panicked at 'attempt to multiply with overflow',
/Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.23/src/naive/datetime/mod.rs:426:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
So my conclusion is:
1. This is definitely a bug
2. The same problem existed in 15.0.0 (so it is not a regression)
3. The issue is upstream in arrow -- i will file a ticket shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
