Goodjooy commented on PR #3399: URL: https://github.com/apache/arrow-rs/pull/3399#issuecomment-1379701695
I am not understanding what this PR's change. - if want handle as much as posiable row in a single batch (even though there might have one or many bad JSON record). returning the error messages togeter with the return value will better . like this : `Result<Option<(RecordBatch, Vec<ErrorSet>)>, ArrowError>` . Returning the error in last batch in `next_batch` is also make user confuse. If just do not want loss any rows. becouse the `Iterator` of rust is lazy, once an error occurred the remain rows of this batch is still in the orginal Iterator that can be take in next batch. for a better understanding ,I am writting a rust-playgound [here](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=5f77d983ffa876d2beeff2fcaa21aada) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
