kou commented on code in PR #33606:
URL: https://github.com/apache/arrow/pull/33606#discussion_r1067737528
##########
cpp/cmake_modules/FindNumPy.cmake:
##########
@@ -96,5 +96,11 @@ find_package_message(NUMPY
set(NUMPY_FOUND TRUE)
add_library(Python3::NumPy INTERFACE IMPORTED)
-target_include_directories(Python3::NumPy INTERFACE ${NUMPY_INCLUDE_DIRS})
+if(CMAKE_VERSION VERSION_LESS 3.11)
+ target_include_directories(Python3::NumPy PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES
+ ${NUMPY_INCLUDE_DIRS})
+ set_target_properties(Python3::Module PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES
Review Comment:
Oh, this is broken code...
We should use `set_target_properties()` + `Python3::NumPy` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
