carols10cents commented on pull request #8590: URL: https://github.com/apache/arrow/pull/8590#issuecomment-721941737
> I do not think that we should remove `impl PartialEq for BufferData`. I am only trying to understand why would we would like to compare two `Buffer` and not take the `ArrayData::offset` into account in the equality. Without the offset, comparing buffers is basically comparing physical memory, and IMO has limited use-cases. I was not proposing that we remove `impl PartialEq for BufferData`, I was only doing that to get the compiler to tell me about all the places we're using it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
