js8544 commented on PR #33608: URL: https://github.com/apache/arrow/pull/33608#issuecomment-1381221712
> Ok, is it possible to exploit this new possibility in some select places? It will validate that it works and also show the benefits. > > (you can of course grep through the codebase to find candidates) Good point. I've applied the new `VisitArrayInline`in column_writer.cc, which saves a copy construction of `std::shared_ptr<Buffer>`. And `VisitTypeInline` in builder.h, which eliminates the need for a wrapper for the visitor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
