waynexia commented on code in PR #4879:
URL: https://github.com/apache/arrow-datafusion/pull/4879#discussion_r1068886119
##########
datafusion/substrait/tests/serialize.rs:
##########
@@ -33,15 +33,15 @@ mod tests {
let sql = "SELECT a, b FROM data";
// Test reference
let df_ref = ctx.sql(sql).await?;
- let plan_ref = df_ref.to_logical_plan()?;
+ let plan_ref = df_ref.into_optimized_plan()?;
Review Comment:
I hadn't noticed when this changed from "to_optimized" to "to_unoptimized".
But as discussed in
https://github.com/datafusion-contrib/datafusion-substrait/pull/35, maybe we
need not to cover optimization in serialize/deserialize phase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
