vibhatha commented on issue #30891: URL: https://github.com/apache/arrow/issues/30891#issuecomment-1381404152
@westonpace there is an issue in defining the `format`. Because all the format definitions depends on the definition on this `file_base.h` base class. It is not very clear how to set this value. Also note that looking into the previous PR: https://github.com/apache/arrow/pull/13959 If `min_rows_per_group` value is set to a higher default value and if we set the `max_rows_per_group`, and in an event of `max_rows_per_group` < `min_rows_per_group`, it fails an existing assertion which make sense. So even in a simpler case where user just needs to set the max value, they may be forced to set the min value. So I would say keeping it 0 as default would be okay. Am I missing any thing here? Appreciate your thoughts on these two points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
