rtpsw commented on code in PR #33648:
URL: https://github.com/apache/arrow/pull/33648#discussion_r1069537893
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -380,6 +501,23 @@ class InputState {
}
}
+ static Result<std::unique_ptr<InputState>> Make(
+ size_t index, TolType tolerance, bool must_hash, bool may_rehash,
+ KeyHasher* key_hasher, ExecNode* node, ExecNode* output,
+ std::atomic<int32_t>& backpressure_counter,
+ const std::shared_ptr<arrow::Schema>& schema, const col_index_t
time_col_index,
+ const std::vector<col_index_t>& key_col_index) {
+ constexpr size_t low_threshold = 4, high_threshold = 8;
Review Comment:
Do we want to keep these hard-coded in this PR?
##########
cpp/src/arrow/compute/exec/test_nodes.h:
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <string>
+
+#include "arrow/compute/exec/options.h"
+#include "arrow/compute/exec/test_util.h"
+
+namespace arrow {
+namespace compute {
+
+struct ConcatNodeOptions : public ExecNodeOptions {
Review Comment:
Perhaps this should be named `BackpressureOptions` and moved to
`arrow/compute/exec/options.h`, while `ConcatNodeOptions` should derive from it
or include it as a member. Not critical for this PR, but seems useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
