paleolimbot commented on code in PR #61: URL: https://github.com/apache/arrow-nanoarrow/pull/61#discussion_r1069833368
########## extensions/nanoarrow_ipc/src/nanoarrow_ipc/nanoarrow_ipc.c: ########## @@ -0,0 +1,352 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <errno.h> +#include <string.h> + +#include "nanoarrow/nanoarrow.h" + +#include "File_reader.h" +#include "Message_reader.h" +#include "Message_verifier.h" +#include "Schema_reader.h" + +#include "nanoarrow_ipc.h" + +#define ArrowIpcErrorSet(err, ...) ArrowErrorSet((struct ArrowError*)err, __VA_ARGS__) Review Comment: It's a good question...probably the advantage of having it live in `arrow-nanoarrow/extensions` is that it can be distributed alongside nanoarrow.c/nanoarrow.h (i.e., all extensions get checked in to arrow-nanoarrow/dist just like the core C library). I did it this way to start off because that's how I would reccomend that another developer build a library on top of nanoarrow (vendor nanoarrow and don't expose nanoarrow.h to your user because they might be vendoring another version of it themselves). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
