westonpace commented on issue #30891: URL: https://github.com/apache/arrow/issues/30891#issuecomment-1382287361
> @westonpace there is an issue in defining the format. Because all the format definitions depends on the definition on this file_base.h base class. It is not very clear how to set this value. Make the format a required constructor property. Get rid of the no-arg constructor. > So I would say keeping it 0 as default would be okay. Am I missing any thing here? A default of 1Mi for `min_rows_per_group` and 64Mi for `max_rows_per_group` should be very reasonable and give better performance than leaving it at `0` in many cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
