alamb commented on code in PR #4826:
URL: https://github.com/apache/arrow-datafusion/pull/4826#discussion_r1070253187
##########
datafusion/optimizer/src/decorrelate_where_in.rs:
##########
@@ -554,14 +636,12 @@ mod tests {
.project(vec![col("customer.c_custkey")])?
.build()?;
- // Query will fail, but we can still transform the plan
let expected = "Projection: customer.c_custkey [c_custkey:Int64]\
- \n LeftSemi Join: customer.c_custkey = __correlated_sq_1.o_custkey
[c_custkey:Int64, c_name:Utf8]\
+ \n LeftSemi Join: Filter: customer.c_custkey =
__correlated_sq_1.o_custkey AND customer.c_custkey = customer.c_custkey
[c_custkey:Int64, c_name:Utf8]\
Review Comment:
After more thought it probably makes sense to do this decorrelation in the
general way (no special case0 as you have done and then we will rely on
subsequent predicate pushdown logic to push the filters back down if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
