heronshoes commented on PR #33654:
URL: https://github.com/apache/arrow/pull/33654#issuecomment-1382822560
### Comment for reviewers
1. Renaming feature by suffix is introduced only for the `keys=[key1, key2]`
case. I think `keys={hash}` case does not require this feature.
2. I added a test for `right_anti`. I think there may be a bug when it
creates empty ChunkedArray data in the Table.
```ruby
table1 = Arrow::Table.new(key: [1])
table = table1.join(table1, "key", type: :right_anti)
#=>
# returns a Table with empty column. This is the expected result.
#<Arrow::Table:0x10c6bf730 ptr=0x7fb62708f530>
key
# But its content is strange ChunkedArray;
table[:key].data
#=>
#<Arrow::ChunkedArray:0x10c6946c0 ptr=0x7fb6276aead0 [
]>
# Empty ChunkedArray is this;
Arrow::ChunkedArray.new([[]])
#<Arrow::ChunkedArray:0x1202e4610 ptr=0x7fb627a59240 [
[]
]>
# Or if it contains null;
Arrow::ChunkedArray.new([[nil]])
#<Arrow::ChunkedArray:0x1203060d0 ptr=0x7fb627a58a40 [
[
null
]
]>
```
I'm not sure this is a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
