[GitHub] [arrow] pitrou commented on a diff in pull request #15244: GH-15239: [C++][Parquet] Parquet writer writes decimal as int32/64

[GitBox]

pitrou commented on code in PR #15244:
URL: https://github.com/apache/arrow/pull/15244#discussion_r1071046755


##########
cpp/src/parquet/properties.h:
##########
@@ -450,6 +451,22 @@ class PARQUET_EXPORT WriterProperties {
       return this->disable_statistics(path->ToDotString());
     }
 
+    /// Enable integer type to annotate decimal type as below:

Review Comment:
   Also, it would be nice if the docstring was more explanatory as to the 
consequences (the reader may not know that this may make the column more 
compact, and not be readable with previous Arrow C++ versions).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org