pitrou commented on code in PR #33684:
URL: https://github.com/apache/arrow/pull/33684#discussion_r1071091965
##########
cpp/CMakeLists.txt:
##########
@@ -49,6 +49,8 @@ endif()
set(ARROW_VERSION "11.0.0-SNAPSHOT")
+set(CMAKE_EXPORT_COMPILE_COMMANDS 1) # Write compile_commands.json
Review Comment:
I don't think we want to enable this by default. You should pass this
yourself to CMake using `-DCMAKE_EXPORT_COMPILE_COMMANDS=1`.
##########
cpp/src/arrow/vendored/datetime/tz.cpp:
##########
@@ -3597,19 +3597,17 @@ tzdb::locate_zone(const std::string& tz_name) const
{
Review Comment:
This is a vendored file (as the file path suggests), so we shouldn't do such
changes to it. Can you revert them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
