paleolimbot commented on code in PR #33693:
URL: https://github.com/apache/arrow/pull/33693#discussion_r1071330792
##########
r/tests/testthat/test-dplyr-join.R:
##########
@@ -82,7 +82,7 @@ test_that("left_join with join_by", {
left_join(
to_join %>%
rename(the_grouping = some_grouping),
- join_by(some_grouping == the_grouping)
+ join_by(some_grouping == the_grouping)
Review Comment:
Is this change intentional?
##########
r/R/dplyr-join.R:
##########
@@ -116,9 +116,8 @@ semi_join.arrow_dplyr_query <- function(x,
y,
by = NULL,
copy = FALSE,
- suffix = c(".x", ".y"),
...) {
- do_join(x, y, by, copy, suffix, ..., join_type = "LEFT_SEMI")
+ do_join(x, y, by, copy, ..., join_type = "LEFT_SEMI")
Review Comment:
Are changes in this file necessary to make the tests pass? (Or do they have
another purpose, like perhaps making this function more consistent with other
arrow join implementations?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
