alamb commented on a change in pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#discussion_r518733998
##########
File path: rust/arrow/src/buffer.rs
##########
@@ -402,19 +407,27 @@ where
let mut result =
MutableBuffer::new(ceil(len_in_bits, 8)).with_bitset(len_in_bits / 64
* 8, false);
- let left_chunks = left.bit_chunks(left_offset_in_bits, len_in_bits);
- let right_chunks = right.bit_chunks(right_offset_in_bits, len_in_bits);
+ let left_slice = left.bit_slice().view(left_offset_in_bits, len_in_bits);
Review comment:
Can you explain the rationale for this change? It seems to use more code
to accomplish the same functionality without any performance improvement. I am
likely missing something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
