BryanCutler commented on a change in pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#discussion_r518862408
##########
File path:
java/memory/memory-netty/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java
##########
@@ -60,9 +59,6 @@
private UnsafeDirectLittleEndian(AbstractByteBuf buf, boolean fake) {
super(buf);
- if (!NATIVE_ORDER || buf.order() != ByteOrder.BIG_ENDIAN) {
Review comment:
Should keep the second check that `buf.order() != ByteOrder.BIG_ENDIAN`
to make sure the wrapped buffer is BE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
