paleolimbot commented on code in PR #33614:
URL: https://github.com/apache/arrow/pull/33614#discussion_r1072344132
##########
r/R/dataset-format.R:
##########
@@ -228,9 +225,32 @@ check_csv_file_format_args <- function(...) {
call. = FALSE
)
}
+}
+
+get_opt_names <- function(args) {
+ opt_names <- names(args)
+
+ # extract names of parse_options, read_options, and convert_options
+ if ("parse_options" %in% names(args) && is.list(args[["parse_options"]])) {
Review Comment:
If it's off-label usage then you probably should error for it...with the new
function we have the opportunity to protect users from off-label usage (which
was very very easy to do with the existing `open_dataset()`). Passing
`parse_options = CsvParseOptions$create(...)` was the first thing I thought to
do and so I imagine somebody else might think to do it, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
