jorisvandenbossche commented on PR #14082: URL: https://github.com/apache/arrow/pull/14082#issuecomment-1385729277
I don't have an informed opinion on the question whether we should still include an implementation in (Py)Arrow itself or not (would we be able to easily create a python package with wheels based on the go driver?) In case the goal is to merge this PR: I took a quick look at just the python changes, which looks good to me. A few high-level comments: - It could use some documentation (also for C++), maybe at a minimum list it in the reference docs? - For pyarrow, purely from the module name (`pyarrow.flight_sql`), it's not very clear that this is an ADBC driver (one could also naively think that this module allows you to implement an actual Flight SQL server). If we use the naming scheme for driver packages in adbc itself, this would probably be like `pyarrow.adbc_driver_flight_sql`, but is clearer, but of course a mouthful .. - Long term, do we have a better testing strategy than the few smoke tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
