tustvold commented on code in PR #3529:
URL: https://github.com/apache/arrow-rs/pull/3529#discussion_r1072507781
##########
arrow-data/src/bitmap.rs:
##########
@@ -68,12 +68,23 @@ impl Bitmap {
self.bits
}
- /// Returns the total number of bytes of memory occupied by the buffers
owned by this [Bitmap].
+ /// Returns the total number of bytes of memory occupied by the
+ /// buffers owned by this [Bitmap].
+ ///
+ /// Note that this [`Bitmap`] may only refer to a subset of the
+ /// data in the underlying [`Buffer`] (it is a slice) but the return
value includes the
+ /// entire size of the buffer.
+ ///
Review Comment:
```suggestion
```
This isn't actually correct, `BitMap` is not sliceable (yet) (#1802)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
