felipecrv commented on code in PR #15083:
URL: https://github.com/apache/arrow/pull/15083#discussion_r1072718775


##########
cpp/src/arrow/compute/api_aggregate.h:
##########
@@ -56,6 +58,13 @@ class ARROW_EXPORT ScalarAggregateOptions : public 
FunctionOptions {
   uint32_t min_count;
 };
 
+class ARROW_EXPORT CountAllOptions : public FunctionOptions {

Review Comment:
   Unfortunately, I can't pass `nullptr` as the "default options" in the kernel 
configuration. I tried, but then it causes crashes because when you pass no 
options in the kernel calls, `options` is set to the default options as after 
some point, `options` is expected to be non-null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to