alamb commented on code in PR #4924:
URL: https://github.com/apache/arrow-datafusion/pull/4924#discussion_r1072918404
##########
datafusion/physical-expr/src/aggregate/count.rs:
##########
@@ -202,7 +202,9 @@ impl RowAccumulator for CountRowAccumulator {
}
fn evaluate(&self, accessor: &RowAccessor) -> Result<ScalarValue> {
- Ok(accessor.get_as_scalar(&DataType::Int64, self.state_index))
+ Ok(ScalarValue::Int64(Some(
Review Comment:
is this change necessary or is it a drive by refactor?
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -151,15 +149,13 @@ impl PhysicalGroupBy {
enum StreamType {
AggregateStream(AggregateStream),
- GroupedHashAggregateStreamV2(GroupedHashAggregateStreamV2),
Review Comment:
this is so wonderful to see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
