mingmwang commented on code in PR #4923:
URL: https://github.com/apache/arrow-datafusion/pull/4923#discussion_r1073180694
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -2328,4 +2324,183 @@ mod tests {
.expect("failed to optimize plan");
assert_optimized_plan_eq(&optimized_plan, expected)
}
+
+ #[test]
+ fn left_semi_join_with_filters() -> Result<()> {
+ let left = test_table_scan_with_name("test1")?;
+ let right_table_scan = test_table_scan_with_name("test2")?;
+ let right = LogicalPlanBuilder::from(right_table_scan)
+ .project(vec![col("a"), col("b")])?
+ .build()?;
+ let plan = LogicalPlanBuilder::from(left)
+ .join(
+ right,
+ JoinType::LeftSemi,
+ (
+ vec![Column::from_qualified_name("test1.a")],
+ vec![Column::from_qualified_name("test2.a")],
+ ),
+ Some(
+ col("test1.b")
+ .gt(lit(1u32))
+ .and(col("test2.b").gt(lit(2u32))),
+ ),
+ )?
+ .build()?;
+
+ // not part of the test, just good to know:
+ assert_eq!(
+ format!("{plan:?}"),
+ "LeftSemi Join: test1.a = test2.a Filter: test1.b > UInt32(1) AND
test2.b > UInt32(2)\
+ \n TableScan: test1\
+ \n Projection: test2.a, test2.b\
+ \n TableScan: test2",
+ );
+
+ // Both side will be pushed down.
+ let expected = "\
+ LeftSemi Join: test1.a = test2.a\
+ \n Filter: test1.b > UInt32(1)\
+ \n TableScan: test1\
+ \n Projection: test2.a, test2.b\
+ \n Filter: test2.b > UInt32(2)\
Review Comment:
I think this method's name `on_lr_is_preserved()` is very miss leading. It
means whether the Join condition can be changed to a Filter condition and push
down. For example, for the Full Out Join, both sides should be preserved in
the join result, but join conditions can not be changed to Filter and pushed
down, and the method returns `(false, false)`.
And per my understanding, LeftSemi/Right Semi join are similar to the Inner
join case, so the implement should return `(true, true)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
