lukester1975 commented on issue #15139: URL: https://github.com/apache/arrow/issues/15139#issuecomment-1386831952
OK. FWIW, I added this patch to vcpkg (along with https://github.com/microsoft/vcpkg/pull/23898/) and tried an install of arrow. It generates: `Libs: "-L${libdir}" -larrow "${prefix}/lib/snappy.lib" "$<$<CONFIG:RELEASE>:${prefix}/lib/bz2.lib>" "$<$<CONFIG:DEBUG>:${prefix}/lib/bz2d.lib>" "$<$<NOT:$<OR:$<CONFIG:RELEASE>,$<CONFIG:DEBUG>>>:optimized" "${prefix}/lib/bz2.lib" "${prefix}/lib/bz2d.lib>"` which doesn't look great. As a quick hack I added `z_vcpkg_setup_pkgconfig_path(BASE_DIRS "${CURRENT_INSTALLED_DIR}/debug")` to the portfile before the `vcpkg_cmake_configure` and end up with: ``` Libs: "-L${libdir}" -larrow Requires: snappy libbrotlidec libbrotlienc zlib liblz4 libzstd bzip2 Cflags: "-I${includedir}" -DARROW_STATIC ``` which looks spot on to me. I'm not sure where to go with this now - a new issue in the vcpkg repo? Whilst `vcpkg_configure_cmake.cmake` has no calls to `z_vcpkg_setup_pkgconfig_path` (whereas `vcpkg_configure_make.cmake`, `vcpkg_configure_meson.cmake` etc. do) I assume that's not an oversight... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
