alamb opened a new pull request, #4972: URL: https://github.com/apache/arrow-datafusion/pull/4972
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/4924 # Which issue does this PR close? re https://github.com/apache/arrow-datafusion/issues/2723 # Rationale for this change Follow on to https://github.com/apache/arrow-datafusion/pull/4924 work from @mustafasrepo and @ozankabak There are several TODOs in the group by hash code as well as some out of date comments that make it harder to work with. Given the thinking / plans to improve this code it is important it remains relatively easy to work with Since I had all the code paged in anyways as I was reviewing https://github.com/apache/arrow-datafusion/pull/4924 I figured I would add my comments here # What changes are included in this PR? 1. Remove extra level of unwrapping in `GroupedHashAggregateStreamInner` 2. Make `group_aggregate_batch` and `create_batch_from_map` member functions rather than free functions (and remove clippy warnings) # Are these changes tested? Existing tests cover these cases (this is a refactor) # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
